Skip to content

Fix res::upgrade() silent fail on missing arguments - #1357

Merged
uNetworkingAB merged 1 commit into
uNetworking:masterfrom
ValoChet:patch-2
Oct 16, 2026
Merged

uNetworkingAB merged 1 commit into
uNetworking:masterfrom
ValoChet:patch-2

Conversation

@ValoChet

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown

Benchmark: 925e483 against 6aa8a01

Scenario Base req/s Head req/s Head / base Rounds Noise Busy CPU per request
http/hello-world 116797 116681 0.999x (-0.1%) 1.00 to 1.01 ±1.6% 100% / 100% 8.56 / 8.55 us (1.000x)
http/headers 104369 105488 1.015x (+1.5%) 1.00 to 1.02 ±1.6% 100% / 100% 9.57 / 9.47 us (0.986x)
http/json-post 85731 85926 1.003x (+0.3%) 1.00 to 1.00 ±1.2% 100% / 100% 11.65 / 11.63 us (0.997x)
http/cached 129978 129508 0.995x (-0.5%) 0.99 to 1.00 ±0.9% 100% / 100% 7.69 / 7.72 us (1.005x)
ws/echo-20b 122050 122801 1.006x (+0.6%) 1.00 to 1.01 ±1.4% 100% / 100% 8.19 / 8.14 us (0.994x)
ws/echo-4kb 105880 105432 0.997x (-0.3%) 0.98 to 1.01 ±2.9% 100% / 100% 9.43 / 9.47 us (1.002x)

4 rounds of 3s per scenario, each round loading base, head and a second process of each one, from a copy of its build, after the other, in an order that changes every round. "Head / base" is the median of the per-round ratios of req/s and "Rounds" their range. "Noise" is how far base/base and head/head, the same code on both sides, got from 1 in this same run: that is what the machine did, so a row is marked only when the median moved further than that, at least 2%, and every round moved the same way: 👀 slower, 🏆 faster. "Busy" is the cpu time of the server process over the round and "CPU per request" that time divided by the requests it answered, with the head/base ratio judged against its own same-code band and bold when it cleared it. When busy is well under 100% the load generator set the pace, the req/s are its and the cpu per request is the column to read. Only the ratios are comparable across runs, the absolute figures depend on the runner.

Node v26.12.0, AMD EPYC 7763 64-Core Processor, 4 cores (server on cpu 0, load on 2,3), http_load_test and load_test with 100 connections.

@uNetworkingAB
uNetworkingAB merged commit caa0217 into uNetworking:master Oct 16, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants