Repository navigation
Conversation
Author
|
@uNetworkingAB could you please review this small fix for OpenSSL session resumption with client-certificate verification when you have a chance? Tested locally with TLS 1.2 and 1.3, including SNI certificate reload and rejection of untrusted client certificates. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When ca_file_name enables client-certificate verification, the initial TLS handshake succeeds but attempting to resume that session can fail with an internal_error alert: OpenSSL requires a session ID context for resumed client authentication.
Initialize a random per-SSL_CTX session ID context in create_ssl_context_from_options, including contexts created for SNI. Check both initialization calls and fail context creation on error. The wolfSSL path and certificate-verification settings are unchanged.