Repository navigation
Add three-buffer socket writes for chunked responses - #262
Open
GetThatCookie wants to merge 1 commit into
Open
GetThatCookie wants to merge 1 commit into
GetThatCookie wants to merge 1 commit into
Conversation
Track partial vectored writes for writable notifications and avoid SIGPIPE on disconnected peers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to the smaller
tryWritealternative to uNetworking/uWebSockets#1922.us_socket_write3lets the chunked response path send corked headers, body and trailing framing in one TCP syscall. This also fixes partial-write tracking for vectored writes and avoidsSIGPIPEon disconnected peers.For a 64 KiB response, this reduces two sends to one. In the streaming benchmark, the three-buffer implementation achieved 10.1% higher throughput than the two-buffer version.