Repository navigation
http_load_test: a {n} in the path changes on every request - #261
Merged
uNetworkingAB merged 1 commit intoOct 8, 2026
Merged
Conversation
nigrosimone
marked this pull request as ready for review
October 8, 2026 11:44
Contributor
|
Waaaait. It shouldn't be pipelined. I never benchmark pipelined. It just a variation for keep-alive. |
Contributor
Author
|
It is not pipelined: pipeline is still 1 unless you pass the pipeline factor (the 5th argument, from 9e1ccc7). With 1 the loop in vary_request runs once, so one request with a new number per write, sent after the previous response. The loop is only there so a pipelined batch gets different numbers too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
{n}in the path becomes a number that changes on every request, so a server cannot answer from the bytes of the request before. The varied URLs case from uNetworking/uWebSockets.js#1352:The number has a fixed width (8 digits) and is written in place before each send, so the request keeps its size. Without
{n}nothing changes.Checked against a uWS.js app counting urls: 696108 requests, 696108 distinct urls, and
/user/0gives one. Same req/s with and without{n}(the server on one core is the limit).