[dfrankland]

Stacked on #1236. Refs TRUNK-22402.

The validate summary is now built once as data, then rendered, the same way #1236 does it for upload. No output changes, and no JSON flag yet.

What changes.

• New cli/src/report/validate.rs. ValidateReport::new works out everything the validate summary says: the matched files, one FileValidation per file, the CODEOWNERS check, the counts and the exit code. The types derive Serialize, with camelCase keys.
• impl EndOutput for ValidateRunResult moves into report/text.rs as render_validate, which reads only the report. The impl stays on ValidateRunResult (built through the report) because the lock-down tests call it.
• main.rs exits with report.exit_code; ValidateRunResult::exit_code is gone.
• validate and upload's validation section now read the same FileValidation. It gains testSuiteCount and testCaseCount, null for a file that wasn't read as exactly one report. Those files are the ones the text lists under "File parse issues".
• FileValidation.parseError is now {error, causes}, like ErrorSummary, instead of a {:#} string. validate has always printed parse errors the way anyhow's {:?} does, and that can't be rebuilt from the joined string. A unit test checks the rebuilt text against anyhow's own output.
• run_validate collects the --hide-banner deprecation and the BEP parse errors as notices, like run_upload. The deprecation is still only logged.

Kept as-is.

• "📚 Validating N files" counts a file once per glob that matches it, while the closing line counts each file once. counts.files is the deduplicated count.
• upload and validate still collect per-file results differently: upload has no entry for a file with no reports and keeps the last of several, where validate reports both as issues.

#1246 is stacked on this. Its JSON test and doc comments are updated for parseError as an object and the two count fields.

Testing.

• The lock-down tests in cli/tests/summary/ pass unchanged.
• cargo test -p trunk-analytics-cli --lib --test summary --test test --test validate: all pass.
• cargo test -p trunk-analytics-cli --test upload: all pass except the three Swift xunit tests, which fail the same way on the base branch locally.
• cargo clippy -p trunk-analytics-cli --tests: no new warnings. cargo fmt --all --check: clean.

🤖 Generated with Claude Code

[codecov-commenter]

Codecov Report

❌ Patch coverage is 93.44262% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.27%. Comparing base (024bef3) to head (a408da5).

Files with missing lines	Patch %	Lines
cli/src/summary_output/text.rs	90.86%	17 Missing ⚠️
cli/src/validate_command.rs	57.14%	3 Missing ⚠️

Additional details and impacted files

@@                                              Coverage Diff                                               @@
##           dylan/trunk-22401-build-the-upload-summary-as-data-separate-from-rendering    #1254      +/-   ##
==============================================================================================================
+ Coverage                                                                       85.17%   85.27%   +0.09%     
==============================================================================================================
  Files                                                                              82       83       +1     
  Lines                                                                           18695    18781      +86     
==============================================================================================================
+ Hits                                                                            15923    16015      +92     
+ Misses                                                                           2772     2766       -6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[trunk-staging-io]

   

Failed Test	Failure Summary	Logs
pending_quarantine_test should be quarantined when run with variant	A test marked as pending was expected to fail but unexpectedly passed.	Logs ↗︎
variant_quarantine_test should be quarantined when run with variant	The test failed because it expected 2 + 2 to equal 5, but the result was 4.	Logs ↗︎
multiple_exception_error_test nested context with multiple failures multiple expectations that fail	The aggregated test failed because three expectations did not match and an additional RuntimeError was raised.	Logs ↗︎
multiple_exception_error_test with before and after hook failures test execution with hook errors	The test failed because both its before and after hooks raised errors, and RSpec could not match the failure to a backtrace line.	Logs ↗︎

... and 3 more

View Full Report ↗︎ ⋅ Docs

[trunk-io]

   

View Full Report ↗︎ ⋅ Docs

[trunk-io]

This pull request was merged into main as part of stacked PR 1265.