Repository navigation
fix(rspec): honor TRUNK_DISABLE_QUARANTINING during the run - #1247
Merged
Merged
Conversation
|
😎 Merged successfully - details. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1247 +/- ##
==========================================
+ Coverage 85.42% 85.62% +0.20%
==========================================
Files 86 86
Lines 19235 19241 +6
==========================================
+ Hits 16431 16476 +45
+ Misses 2804 2765 -39 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
The gem documents TRUNK_DISABLE_QUARANTINING ("Set to 'true' to disable
quarantining"), but it only ever reached the upload step. The check
that runs when a test fails never read it, so failures were still
looked up and quarantined.
With TRUNK_DISABLE_QUARANTINING=true, a failure is no longer looked up
or quarantined, and the run ends with a note saying so. The gem's upload
telemetry reports the quarantine query result as Disabled rather than
Skipped, as the CLI does for --disable-quarantining.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
dfrankland
force-pushed
the
dylan/rspec-honor-trunk-disable-quarantining
branch
from
October 29, 2026 17:40
253185c to
dce23cf
Compare
Member
Author
|
/trunk merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RSpec gem documents
TRUNK_DISABLE_QUARANTINING("Set to 'true' to disable quarantining") intrunk_spec_helper.rband on the RSpec page at docs.trunk.io, but it never worked. #824 passed the variable only to the upload step. The quarantine check that runs when a test fails never read it, so with it set the gem still looked failures up and quarantined them, and RSpec still passed.What changes.
TRUNK_DISABLE_QUARANTINING=true, a failing example isn't looked up or quarantined, so the failure stands. At the end of the run the gem prints "Note: TRUNK_DISABLE_QUARANTINING is set. Test failures were not quarantined." The value has to be exactlytrue, as with the gem's other flags and the upload's parsing of this one.Disabledrather thanSkipped, as the CLI does for--disable-quarantining.Release note. Anyone who already sets
TRUNK_DISABLE_QUARANTINING=truefor RSpec will now see failures that used to be quarantined fail their run, which is what the setting always claimed to do.Testing.
test_reporttest: publishing with the variable set reportsDisabledin telemetry. It reportsSkippedwithout the fix.bundle exec rake test(the gem's suite) andcargo test -p test_report: all pass.ifincloseand the new predicate onclass << selfpush those two over their limits, so both are added totrunk-ignore, like the file's other long methods.🤖 Generated with Claude Code