Repository navigation
Conversation
Fixes trentm#55 Signed-off-by: Don Yin <Don_Yin@outlook.com>
Signed-off-by: Don Yin <Don_Yin@outlook.com>
Crozzers
reviewed
Oct 27, 2026
| Python-markdown (markdown.py). | ||
| """ | ||
|
|
||
| def test_link_pattern_url_encoding(self): |
Contributor
There was a problem hiding this comment.
This should go as a test file in test/tm-cases. Better error formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #55.
link-patternswrote the generated destination intohrefas is, so a pattern producing a target with spaces gavehref="lorem foo bar ipsum". I URL-encode it withurllib.parse.quote, keeping URL delimiters and existing%escapes, so normal URLs come out unchanged.I added a test for the case in the issue. The full test suite and
make testredospass locally.