Repository navigation
Conversation
Author
|
Could a maintainer approve the check workflow for the current head ( |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
os.pathsep.join(str(i) for i in self._backend_paths).strip() removes a valid trailing space from the final backend directory. A backend located in a POSIX directory named 'backend ' cannot be imported by the real child process.
Remove only .strip() from the joined backend-path string. Add three real child-process backend tests for ordinary names, embedded spaces and a trailing space. No changelog fragment is added: current comparable merged PR #326 changes only implementation and tests, and no mandatory fragment rule was found.
Testing
118 tests passed; the configured 100% coverage gate passed (1,204 statements and 136 branches). Ruff check, Ruff format check and the declared ty 0.0.24 type checker passed. A clean applied checkout built a wheel and passed all 3 new cases. Full Python 3.12 suite and the 100% coverage gate passed. The repository-wide type check passed using ty 0.0.24 with its declared type/docs dependencies.
Removing strip preserves filesystem spelling; joining zero paths still returns an empty string. No shell is introduced and argv remains unchanged. Only the trailing-space filesystem case is skipped on Windows; ordinary and embedded-space cases remain portable.
Validation results above are from the reviewed patch on upstream commit
d248e76ec2a23f8d13f1abc2e49e8c1d037c9a2d.