Skip to content

fix: resolve Windows projects with an empty HOME - #635

Open
pabszero wants to merge 4 commits into
tox-dev:mainfrom
pabszero:fix-windows-empty-home
Open

pabszero wants to merge 4 commits into
tox-dev:mainfrom
pabszero:fix-windows-empty-home

Conversation

@pabszero

Copy link
Copy Markdown

Fixes #634. After #627, an empty HOME makes Windows().user_projects_dir raise even with a valid USERPROFILE. Restrict the empty-HOME/password-database workaround to POSIX so Windows follows its normal USERPROFILE or HOMEDRIVE/HOMEPATH lookup. An actually unresolved home still raises.

Add one Windows regression and document the lookup rule. The regression fails with RuntimeError before the guard.

Validation on Windows:

  • Tox CPython 3.12.14 and 3.13.5: 2,042 passed, 350 skipped each; 100% diff coverage. Unchanged 3.13 baseline: 2,041 passed, 350 skipped.
  • Ty, Proselint, Sphinx -W, wheel/sdist builds, Twine and wheel-content checks passed.
  • All configured pre-commit hooks pass on the full repository through Tox (fix).

Checks used task-local Windows WMI/tool-bootstrap overrides and CPython 3.13 for tooling (including Proselint, normally launched under 3.14). Repository test/build/hook configuration is unchanged. The unmodified tox r invocation and other platforms/interpreters are not claimed; all selected checks above passed with those local bootstrap overrides. Hosted CI remains unverified.

Found and prepared with OpenAI Codex assistance.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows projects directory raises with empty HOME and valid USERPROFILE

1 participant