Repository navigation
✅ test(strict-soft): check a closed descriptor by errno - #875
Merged
gaborbernat merged 1 commit intoOct 28, 2026
Merged
gaborbernat merged 1 commit into
gaborbernat merged 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a Chinese-language Windows,
test_strict_soft_sentinel_inspection_failure_closes_descriptorfailed because it matched the English text of the closed-descriptor error, and Windows reports that text in the system language ([WinError 6] 句柄无效。). The lock had closed the descriptor as intended; only the assertion depended on the locale. Contributors on a non-English Windows can now run the suite without a spurious failure.The test now checks
errno == EBADFthrough thecheck=predicate ofpytest.raises, the same shape the suite already uses for the symlink refusal errnos. The errno is the same on every platform, while the message is not. The remaining message matches in the suite target Python-generated or C-runtime text, which stays English regardless of the system language.