Repository navigation
Conversation
…orm-updates PM-6633 lead intake form updates
…orm-updates PM-6636 - Engagement Leads page changes
…orm-updates PM-6682 - copy skills from lead to engagement
…hboards-dev PM-6688 Quarterly sales dashboards and sortable tables -> dev
What was broken Appeal responses displayed Accepted when the reviewer selected the original score, including the reported score of 7 with a response of "No change". Root cause The save handler treated any nonempty score selection as a successful appeal. What was changed Compare the resulting review answer with the original answer when creating or editing an appeal response. Unchanged and reverted scores are rejected, while text-only edits preserve acceptance when the score remains changed. Any added/updated tests Add 20 create/edit regression cases covering unchanged scores, changed scores, reverted scores, text-only edits, zero scores, and yes/no answers. Add two tests for the visible Accepted/Rejected label. All 25 focused tests and repository-wide lint pass. The full suite has unrelated failures documented in the PR. The development-environment production build also passes.
What was broken Attaching XML files in a forum topic or comment failed with a generic error. Root cause Filestack rejects application/xml and text/xml uploads with HTTP 403 (content not allowed), and its rejection reaches the forum's generic error handler. What was changed Store XML attachments as application/octet-stream downloads, recognizing the XML filename extension or MIME type. Preserve the original file and filename and keep other attachment types unchanged. Any added/updated tests Add five XML upload regression cases and a topic-creation test that includes an XML download link. Verify non-XML image uploads retain their existing options. All 54 focused tests pass. Real Chromium uploads for both XML MIME types and an empty browser MIME type pass and preserve the downloaded XML bytes. Full lint and the development build pass (build warnings remain). The full test run has 409 passing and 20 failing suites. Nineteen failures reproduce on unchanged dev; the remaining Salesforce suite passes individually on both dev and this branch.
PM-6657: Allow XML forum attachments
PM-6674: Reject appeals when the original score is unchanged
PM-6684 - fix wipro forms
Pm 6684 wipro forms
…ue-dev PM-6700 PM-6697 Revenue Forecast and FY Closure -> dev
PM-6690 - Allow users to submit timesheet records with 0 hours
Deploy Platform UI through scoped CircleCI OIDC with production approval
…i-input Fix Platform UI dev configuration download with the pinned AWS CLI
…r-production Deploy Platform UI production from master with manual approval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://topcoder.atlassian.net/browse/PM-6633
https://topcoder.atlassian.net/browse/PM-6637
https://topcoder.atlassian.net/browse/PM-6636
https://topcoder.atlassian.net/browse/PM-6655
https://topcoder.atlassian.net/browse/PM-6682
https://topcoder.atlassian.net/browse/PM-6679
https://topcoder.atlassian.net/browse/PM-6680
https://topcoder.atlassian.net/browse/PM-6681
https://topcoder.atlassian.net/browse/PM-6683
https://topcoder.atlassian.net/browse/PM-6684
https://topcoder.atlassian.net/browse/PM-6685
https://topcoder.atlassian.net/browse/PM-6684
https://topcoder.atlassian.net/browse/PM-6689
https://topcoder.atlassian.net/browse/PM-6693
https://topcoder.atlassian.net/browse/PM-6690
https://topcoder.atlassian.net/browse/PM-6694
https://topcoder.atlassian.net/browse/PM-6695
https://topcoder.atlassian.net/browse/PM-6701