Repository navigation
Expose lines leaving the terminal viewport - #158
Merged
Merged
Conversation
tomlm
requested review from
JohnCampionJr
and
a balanced review from Copilot
September 27, 2026 02:54
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Downward scrolling, reset-driven deactivation, and metadata-only rows can currently lose lines without notification.
Review effort: Balanced
Findings: 3
Open (4)
What changed in this PR
Adds notifications for lines leaving the active terminal viewport.
Changes:
- Introduces
LineExitedViewportand exit-reason metadata. - Emits notifications during upward scrolling and buffer switches.
- Adds coverage for scrolling, margins, and buffer switching.
| File | Description |
|---|---|
Terminal.cs |
Exposes and raises viewport-exit events. |
Events/TerminalEvents.cs |
Defines event arguments. |
Common/Types.cs |
Defines line-exit reasons. |
Buffer/TerminalBuffer.cs |
Emits notifications during upward scrolling. |
LineExitedViewportTests.cs |
Tests core event behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
|
@simonefil this is a good idea; can you address the code reviews from copilot please? |
Contributor
Author
|
Thanks for the review! All four Copilot findings have now been addressed in 1ff4cec, i also added regression tests for these cases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Motivation
Headless terminal hosts may need to persist or process rows as they leave the active viewport. One example is maintaining an external, bounded history that survives beyond
XTerm.NET's in-memory scrollback.
The existing
Scrolled,Trimmed, andBufferChangedevents do not provide the affectedBufferLinebefore it is moved, removed, or recycled. A host therefore cannot reliablycapture the final contents and attributes of that row.
Changes
This adds a
LineExitedViewportevent toTerminal. The event reports:BufferLineleaving the viewport;Scroll notifications are raised synchronously before the line can be spliced or recycled. Full-width scroll regions are supported; narrowed left/right margins do not raise the
event because they move only part of each row.
When switching buffers, the event is raised for meaningful visible rows before the previous buffer is deactivated. Trailing empty rows are omitted.