Skip to content

fix(async): raise APIConnectionError when reading the response body fails #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pcbeingused333 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(async): raise APIConnectionError when reading the response body fails #480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/together/abstract/api_requestor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,7 +685,7 @@ async def binary_stream_generator() -> (
except (aiohttp.ServerTimeoutError, asyncio.TimeoutError) as e:
raise error.Timeout("Request timed out") from e
except aiohttp.ClientError as e:
utils.log_warn("Error reading API response")
raise error.APIConnectionError("Error reading API response") from e

if content_type in ["application/octet-stream", "audio/wav", "audio/mpeg"]:
# Binary content - keep as bytes
Expand Down
21 changes: 21 additions & 0 deletions tests/unit/test_async_response_read_error.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
from unittest.mock import AsyncMock, MagicMock

import aiohttp
import pytest

from together import error
from together.abstract.api_requestor import APIRequestor
from together.types import TogetherClient


@pytest.mark.asyncio
async def test_async_read_connection_error_raises_api_connection_error():
requestor = APIRequestor(client=TogetherClient(api_key="fake_api_key"))

response = MagicMock()
response.headers = {"Content-Type": "application/json"}
response.status = 200
response.read = AsyncMock(side_effect=aiohttp.ClientConnectionError("reset"))

with pytest.raises(error.APIConnectionError):
await requestor._interpret_async_response(response, stream=False)