Repository navigation
[Docs] Follow the backend example's tuning tests, and state the backends page without implementation-specific counts - #75
Merged
Conversation
…on master The example now defines request_tune() and config on its kernels and checks them in tests/test_tuning.py (lcy-seso/tileops-backend-example#4), so the layout table lists that file, the test run reports 28 passed, and the template steps carry over five test files. The link to the example's tests named a main branch the repository does not have; it names master.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
… the implementation The page gave the test count, the GPU it was run on, the dev image's tilelang tag, the number of test files and how many kernels GEMM declares; each goes stale with the next change. It now says the tests all pass with and without a GPU, takes <tag> from the development guide, and leaves the counts out. The template step names every name the tests depend on: package, target, op and kernel class. The Chinese page also drops colloquial phrasing and spaces Latin terms from Chinese text.
… pick the dev-image tag The template step listed only names to substitute; the tests also create tensors on CPU and assert the CPU device type, and some assertions are specific to an op or kernel. The dev-image guide gives the tag's form, not a current tag, so the page asks for a published tag in that form.
…ileOPs has today The marker table listed sm80 to sm90 and called them, with two other markers, three markers. A new architecture marker would leave the list incomplete; the table now names the form sm<NN> and three kinds of marker. The Chinese page also spaces a link from the text that follows it, as elsewhere on the page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems
tests/test_tuning.py; thebackendspage lists four test files and 24 passed.tests/points attree/main, which returns 404: the repository's branch ismaster.Changes
tests/test_tuning.py, English and Chinese.<tag>, in the form the development guide's dev-image section gives.tree/master/tests. GEMM "declares several" kernels.sm<NN>, and counts three kinds of marker.