Skip to content

[SCAL-345892] add showSpotterLimitations support - #728

Open
chenma-TS wants to merge 2 commits into
mainfrom
SCAL-345892-app-embed-spotter-limitations
Open

chenma-TS wants to merge 2 commits into
mainfrom
SCAL-345892-app-embed-spotter-limitations

Conversation

@chenma-TS

@chenma-TS chenma-TS commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator
  • Add showSpotterLimitations to AppViewConfig
  • Add app.spec cases for true and false
  • Regenerate typedoc

@chenma-TS
chenma-TS requested a review from a team as a code owner October 28, 2026 23:11

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the showSpotterLimitations configuration option to the AppEmbed component, enabling control over the visibility of chat limitation text under the Spotter input. The changes include updating the AppViewConfig interface, parameter mapping logic, and adding corresponding unit tests. The review feedback points out a style guide violation in the JSDoc comment for showSpotterLimitations, suggesting proper capitalization and punctuation.

Comment thread src/embed/app.ts Resolved
@pkg-pr-new

pkg-pr-new Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@thoughtspot/visual-embed-sdk@728

commit: 3df0553

Comment thread src/embed/app.ts Resolved
Comment thread src/embed/app.ts Resolved
@mouryabalabhadra

Copy link
Copy Markdown
Collaborator

Empty PR description and run npm run docgen

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants