Repository navigation
[SCAL-332718]: add menuIndex to CustomAction, validate it as MENU-only - #724
Open
tushardeepakts wants to merge 2 commits into
Open
tushardeepakts wants to merge 2 commits into
tushardeepakts wants to merge 2 commits into
Conversation
tushardeepakts
changed the title
tushardeepakts
force-pushed
the
SCAL-332718
branch
from
October 23, 2026 05:55
c1aefff to
5e2765d
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for a menuIndex property on custom actions to specify their position in the menu, and enforces a limit of two primary actions per target. The reviewer identified that the implementation incorrectly preserves the original input order of actions with a menuIndex rather than sorting them by their index value. They provided actionable code suggestions to sort these actions ascendingly by menuIndex and to update the corresponding unit tests to verify this behavior.
commit: |
tushardeepakts
force-pushed
the
SCAL-332718
branch
from
October 23, 2026 06:03
ac22de1 to
b740a1b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds optional
menuIndexto code-based custom actions, allowing developers to control whereMENUactions appear in the "More" menu.Changes
CustomAction.menuIndex.menuIndexfor Liveboard, Viz, Answer, and Spotter targets. OnlyMENUactions support it; other positions returnINVALID_MENU_INDEX_POSITION.menuIndex(stable for ties), followed by actions sorted alphabetically.Host Dependency
The SDK validates and orders actions; blink-v2 handles inserting them into the specified menu slots.