Repository navigation
Conversation
Replace backslashes with forward slashes in normalized file paths.
Add tests for normalizing backslash separators in file paths across different platforms.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sanitize_filepath(r"a\b\..\c.txt", platform="windows")leaves the..component on Linux, whereas the equivalent slash-separated input becomesa\c.txt. The sanitizer already treats backslashes as separators, but only after calling the host'sos.path.normpath.Translate the separators before normalization so dot components are resolved consistently for both input styles. Drive splitting, component sanitization, output separators and the
normalize=Falsepath stay in place.Added 26 cases covering mixed separators,
./.., string/Path inputs, Windows drive/UNC/root paths, unchanged paths and the normalization opt-out. On the unmodified base, 14 cases fail and 12 controls pass.Validation on Linux:
Windows/macOS, Python 3.13/3.14 and PyPy CI were not run locally. Nine additional checks with the Windows path normalizer pass, but are not a substitute for the Windows CI job. Existing warnings remain.