Fix test_run_with_command_flags on macOS (BSD printenv) - #709
Merged
theskumar merged 2 commits intoSep 30, 2026
Merged
Conversation
The test used printenv --version to check that dotenv run forwards flags. GNU printenv accepts that flag; BSD printenv on macOS does not, so the suite fails even though flag forwarding works. Use the current Python interpreter's --version instead. Fixes theskumar#708
`dotenv run` has no `--version` option, so the pre-theskumar#607 code forwarded it too and the test couldn't catch a regression. Forward `--help` instead, which `run` would otherwise handle, and assert the exact argv the command receives.
Owner
|
Thanks @ekanshul, the switch to While reviewing, I noticed the test couldn't catch the regression it was written for (#607). check_process(result, exit_code=0, stdout="['--help']\n")Mutation results for
This also drops the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #708.
test_run_with_command_flagsranprintenv --versionto prove thatdotenv runforwards flags instead of swallowing them. That only works with GNU printenv. On macOS, BSD printenv rejects--version(illegal option -- -) and the test fails even though forwarding is correct.This switches the sentinel command to
sys.executable --version, which behaves the same on Linux, macOS, and Windows.