Repository navigation
Fix JIT page protection errors being ignored - #359
Merged
Merged
Conversation
SChernykh
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #241 moved
virtual_memoryto C,setPagesRW,setPagesRXandsetPagesRWXignore the result ofmprotect/VirtualProtect. On systems that don't allow executable JIT pages, for example with systemd'sMemoryDenyWriteExecute=yes(monero-project/monero#10180) or Windows' Arbitrary Code Guard,randomx_alloc_cacheandrandomx_create_vmsucceed and the first dataset initialization or hash crashes, instead of returning NULL as documented.This returns the
pageProtectresult from these functions and throws in the JIT compilers when it fails, like theallocMemoryPagescheck. The secure VM constructor andrandomx_alloc_cachemake the JIT buffer executable once, sorandomx_create_vmandrandomx_alloc_cachereturn NULL on such systems.