Repository navigation
Fix misaligned stores in the RISC-V vector JIT - #356
Merged
SChernykh merged 1 commit intoOct 16, 2026
Merged
Conversation
SChernykh
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generateProgramVectorRV64patches instructions into the generated code throughuint32_t*pointers, but that code contains compressed instructions, so these addresses are only guaranteed to be 2-byte aligned. With-fsanitize=alignment,randomx-benchmark --verify --jit --softAeson RISC-V with the vector extension reports:memcpythrough auint32_t*, as formx_xor, isn't enough: Clang still assumes 4-byte alignment and emitssw. This usesuint8_t*pointers andmemcpyfor all of these stores. The generated JIT code is unchanged.