Repository navigation
Fix HAVE_POSIX_MEMALIGN not being defined - #355
Merged
Merged
Conversation
SChernykh
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
posix_memaligncheck added in #317 only sets a CMake variable soHAVE_POSIX_MEMALIGNis never defined andrx_aligned_allocstill falls back tomallocin the portable fallback ofintrin_portable.h(RISC-V, s390x, 32-bit ARM, ...). The cache, dataset, scratchpad and VM then only getmalloc's alignment instead of 64 bytes. With-fsanitize=alignmenton RISC-V,randomx-benchmark --verify --jit --softAes --threads 2reports:On 32-bit ARM, glibc's
malloconly guarantees 8-byte alignment, and Clang's NEON code inrandomx_vm::initialize()(vld1.64 {d18, d19}, [r1:128]!) crashes with SIGBUS when the VM is not 16-byte aligned.This defines it when the check passes, as is done for
HAVE_HWCAP.