Repository navigation
fix(nodejs): publish @terraphim/autocomplete with its native binaries - #1013
Open
AlexMikhalev wants to merge 3 commits into
Open
AlexMikhalev wants to merge 3 commits into
AlexMikhalev wants to merge 3 commits into
Conversation
Version 1.3.0 cannot load: its tarball has no binary and the platform packages it needs were never published. The workflow copied binaries to a directory excluded from the package, pinned dependencies that do not exist, and published to GitHub Packages rather than npm. Generate correctly named platform packages, pinned to the release version, and refuse a partial build. Install the packed tarballs on each platform and run a search before publishing to npm, then repeat from the registry. Stop the hand-publish script releasing a single-platform package. Refs #3556 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The workspace resolves crates from the private terraphim registry, and rust-toolchain.toml pins 1.96, so targets added to stable were unused. Refs #3556 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
GitHub runners receive 403 downloading from the private registry, and a public package should not depend on it. Its own dependencies are all on crates.io; it only reached the registry as a workspace member. Give it its own workspace, as the public LSP packages have, and commit its lockfile. Committed without the pre-commit hook, by agreement: its workspace check fails on this machine on an unmodified base because the local mirror lacks a locked crate. Refs #3556 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@terraphim/autocomplete@1.3.0cannot load on any platform:Cannot find module 'terraphim_ai_nodejs-darwin-universal'. Its tarball contains onlyindex.js,package.jsonand the README.Causes
npm/, whichfilesexcludes from the package.optionalDependenciespinned@terraphim/autocomplete-*@1.0.0, none of which exist, whilenpm/*usedterraphim-ai-nodejs-*names.darwin-x64andlinux-x64-gnuhad no directory.Changes
scripts/prepare-npm-packages.mjsgenerates the platform packages, pins them to the release version and refuses a partial build.scripts/publish-to-npmjs.shnow refuses a real publish.Windows on Arm is no longer declared because it has never been built.
npm/win32-arm64-msvcandnpm/darwin-universalare now unused and can be removed separately.Not done by this PR: publishing. After merge, 1.3.1 still needs releasing, and 1.3.0 deprecating.
Refs #3556
🤖 Generated with Claude Code