Repository navigation
feat!(extstore): add new concurrency controls for external storage. - #1917
Open
cconstable wants to merge 11 commits into
Open
cconstable wants to merge 11 commits into
cconstable wants to merge 11 commits into
Conversation
cconstable
force-pushed
the
extstore-concurrency-controls
branch
from
October 2, 2026 21:05
f88df78 to
cf8a627
Compare
tconley1428
reviewed
Oct 5, 2026
tconley1428
reviewed
Oct 5, 2026
tconley1428
reviewed
Oct 5, 2026
tconley1428
reviewed
Oct 5, 2026
tconley1428
reviewed
Oct 5, 2026
cconstable
force-pushed
the
extstore-concurrency-controls
branch
from
October 6, 2026 19:19
cf8a627 to
8d3eb8f
Compare
jmaeagle99
requested changes
Oct 6, 2026
jmaeagle99
reviewed
Oct 16, 2026
…e concurrency limits. Removed dead code.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
ExternalStoragenow has aconcurrencyfield with two limits:max_driver_operationscaps requests in flight for a single client or worker. Each client and each worker gets its own limit.max_operations_per_messagecaps requests for a single message (workflow activation, etc). Each message gets its own budget.Both limits are cooperative. Drivers receive a limiter on the
storeandretrievecontexts and must wrap each request inpermit. Requests made outside apermitare not counted, and a warning is logged when a driver completes without taking one.Removed the
max_workflow_task_external_storage_concurrencyWorkerargument. The payload visitor now walks a message's payload sitesmax_operations_per_messageat a time. The bundled S3 driver takes permits.Why?
The previous control bounded payload visits rather than driver calls, so setting it to 3 did not limit external storage requests to 3. It also only applied to workflow tasks, leaving client, activity, and Nexus paths unbounded.
max_driver_operationsis scoped to a client or worker so thatExternalStoragestays configuration. Holding the counter there meant two clients built from one config silently shared a limit.Checklist
Added tests