[SDK Sentinel] Stabilize timed-out workflow query test - #3119
Open
sdk-sentinel-bot wants to merge 1 commit into
Open
sdk-sentinel-bot wants to merge 1 commit into
sdk-sentinel-bot wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
This PR contains untrusted AI-generated code. Do not approve or run CI until a maintainer has reviewed the diff. SDK Sentinel verified that GitHub Actions remained approval-gated with zero executable jobs when this PR was opened.
Summary
Stabilize the timed-out workflow query test seen in the captured main-branch Java 11 CLI job and repeated same-SHA PR attempts. There are no breaking changes or coordinated server changes.
Root cause
Between the [preceding successful main workflow](https://github.com/temporalio/sdk-java/actions/runs/37029728465) and the [first bad main workflow](https://github.com/temporalio/sdk-java/actions/runs/37068414255), the one-second run timeout raced a five-second local activity. Because that activity held the first workflow task open, execution could close before the trace had replayable workflow-task state, causing the post-timeout query to be rejected.
Fix
Run the sleep activity as a regular activity. Scheduling it commits the workflow task and trace before timeout, while the workflow still times out waiting for activity completion. Existing assertions remain unchanged.
Validation
Five focused pre-change attempts did not reproduce the failure; five post-change Java 11 CLI attempts passed. The unchanged baseline passed. The canonical candidate validator was blocked by read-only submodule git metadata, while the equivalent check excluding only those maintenance tasks passed. Full CLI and Edge CI remain required.
Validation status:
validation-incompletehighhighhighstandard— 1 changed file; 1.0 KiBnot-reproduced— Five actual pre-change Java 11 CLI runs passed. Earlier harness setup attempts did not reach tests because Gradle cache or submodule metadata was read-only.pass-after-only— The existing regression test passed five post-change attempts, but it also passed five focused pre-change attempts; CI full-suite load remains the reproduction environment.Gradle formatting and test-source compilation) — passedGradle formatting and test-source compilation) — did not pass (failure)Investigator-run checks
GRADLE_USER_HOME="$PWD/.ci-flake-runtime/tmp/gradle-home" ./gradlew --offline --no-daemon :temporal-sdk:cleanTest :temporal-sdk:test -x :temporal-serviceclient:initSubmodules -x :temporal-serviceclient:updateSubmodules -x :temporal-sdk:compileJava17Java -PtestServer=dev-server -PtestJavaVersion=11 --tests "io.temporal.workflow.TerminatedWorkflowTest"— passed; 5 attempt(s). Five pre-change attempts passed; natural reproduction did not occur.GRADLE_USER_HOME="$PWD/.ci-flake-runtime/tmp/gradle-home" ./gradlew --offline --no-daemon :temporal-sdk:cleanTest :temporal-sdk:test -x :temporal-serviceclient:initSubmodules -x :temporal-serviceclient:updateSubmodules -x :temporal-sdk:compileJava17Java -PtestServer=dev-server -PtestJavaVersion=11 --tests "io.temporal.workflow.TerminatedWorkflowTest"— passed; 5 attempt(s). Five post-change Java 11 CLI-backed attempts passed../gradlew --offline :temporal-sdk:spotlessApply -x :temporal-serviceclient:initSubmodules -x :temporal-serviceclient:updateSubmodules— passed; 1 attempt(s). The affected module was formatted successfully..ci-flake-runtime/input/validate.sh— failed; 1 attempt(s). The fixed validator reached spotless checks but was blocked when Gradle tried to write read-only .git submodule configuration; the trusted unchanged baseline had succeeded../gradlew --offline --no-daemon spotlessCheck testClasses -x test -x :temporal-serviceclient:initSubmodules -x :temporal-serviceclient:updateSubmodules— passed; 1 attempt(s). The equivalent repository check passed when only the sandbox-blocked submodule-maintenance tasks were excluded.Required target CI
Residual risks
Automation provenance
be01e60acc1e2ccfb20e783a9770bad745ed85c1If this finding should not be fixed, apply the
sdk-sentinel:false-positivelabel and close the PR. Sentinel will suppress the finding until its affected source changes.SDK Sentinel recurrence history
2026-10-02 21:53 UTC2026-10-02 21:53 UTC