Skip to content

winit-host: flush queued writes when the frame cannot be acquired #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtdowling merged 1 commit into from
Oct 12, 2026
Merged

winit-host: flush queued writes when the frame cannot be acquired #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions native/rust/winit-host/src/graphics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1930,12 +1930,18 @@ impl Graphics {
CurrentSurfaceTexture::Success(frame) => (Some(frame), false),
CurrentSurfaceTexture::Suboptimal(frame) => (Some(frame), true),
CurrentSurfaceTexture::Timeout | CurrentSurfaceTexture::Occluded => {
return Ok(false)
// The frame's buffer writes are already queued. Submitting
// nothing still flushes them; returning without a submit
// leaves every write's staging buffer pending, and a hidden
// or occluded window then grows without bound.
self.queue.submit(std::iter::empty());
return Ok(false);
}
CurrentSurfaceTexture::Outdated | CurrentSurfaceTexture::Lost => {
// Both mean the surface no longer matches the window. Rebuilt
// here and drawn next frame, which is one dropped frame rather
// than a dead window.
// than a dead window. The queued writes are flushed as above.
self.queue.submit(std::iter::empty());
if let Some(surface) = &self.surface {
surface.configure(&self.device, &self.config);
}
Expand Down
Loading