Skip to content

PE-1482: Pin Node.js and add the scheduled version bump - #48

Merged
mpsq merged 3 commits into
mainfrom
node-version-from-nvmrc
Oct 22, 2026
Merged

mpsq merged 3 commits into
mainfrom
node-version-from-nvmrc

Conversation

@mpsq

@mpsq mpsq commented Oct 22, 2026 •

Copy link
Copy Markdown
Member

PE-1482

CI already reads .nvmrc, and Dependabot cannot update that file. This adds a scheduled job that opens a one-file .nvmrc PR when a newer release of the same major is out.

  • .nvmrc goes from 24 to 24.22.1. The bump only touches exact versions
  • scheduled-node-version-bump.yml runs at 06:00 and 18:00 UTC. It is a copy of the node-version-bump workflow in team-plain/github-actions, since a public repo cannot call a reusable workflow from a private one. It opens PRs with the GH_WORKFLOW_APP_* app so CI runs on them
  • The Node 22/24 test matrix is unchanged

Note

Low Risk
Changes are limited to .nvmrc and a new automation workflow; no application or auth logic is modified.

Overview
Pins Node.js to an exact version in .nvmrc (24 → 24.22.1) so CI/release workflows that read that file use a specific patch release instead of a major-only pin.

Adds a scheduled GitHub Actions workflow (scheduled-node-version-bump.yml) that runs twice daily (and on manual dispatch). It checks whether a newer release in the same major exists on nodejs.org; if .nvmrc is already an exact semver and an update is available, it opens or updates a single PR on branch node-version-bump via the GH_WORKFLOW_APP_* GitHub App so CI runs on the bump. Major-only values in .nvmrc are left alone (no-op with a notice).

Reviewed by Cursor Bugbot for commit bb9f667. Bugbot is set up for automated code reviews on this repo. Configure here.

Runs a copy of the node-version-bump workflow from team-plain/github-actions at 06:00 and 18:00 UTC. A public repo cannot call a reusable workflow from a private one, so the job lives here. It only bumps an exact version, so .nvmrc goes from 24 to 24.22.1.
@mpsq
mpsq requested a review from a team as a code owner October 22, 2026 09:34
@greptile-apps

greptile-apps Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge based on the changes since the previous review.

Reviews (2) · Last reviewed commit: "Apply suggestion from @mpsq" · Reviewed by Greptile

@mpsq
mpsq enabled auto-merge (squash) October 22, 2026 09:39
@mpsq
mpsq disabled auto-merge October 22, 2026 09:39
@mpsq
mpsq merged commit 83c7029 into main Oct 22, 2026
11 checks passed
@mpsq
mpsq deleted the node-version-from-nvmrc branch October 22, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants