Repository navigation
fix: don't reuse the parent's HTTP connections in forked children (bug 2088960) - #1095
Merged
Merged
Conversation
jcristau
changed the title
Eijebong
approved these changes
Nov 4, 2026
Eijebong
left a comment
Eijebong
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just one nit in the test. Really surprised it took this long to discover this tbh
jcristau
force-pushed
the
fork-reset-sessions
branch
from
November 4, 2026 16:20
2ad30e8 to
c184d44
Compare
…g 2088960) Taskgraph forks a child per kind, and the children inherited the cached requests sessions, and the keep-alive connections pooled in them, from the parent. Two children using the same host at the same time then shared one TLS socket and corrupted each other's stream, failing with SSL: RECORD_LAYER_FAILURE. Clear the get_session and get_taskcluster_client caches after fork in the child.
jcristau
force-pushed
the
fork-reset-sessions
branch
from
November 4, 2026 16:21
c184d44 to
6966d31
Compare
jcristau
enabled auto-merge (squash)
November 4, 2026 16:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taskgraph forks a child per kind, and the children inherited the cached requests sessions, and the keep-alive connections pooled in them, from the parent. Two children using the same host at the same time then shared one TLS socket and corrupted each other's stream, failing with SSL: RECORD_LAYER_FAILURE.
Clear the get_session and get_taskcluster_client caches after fork in the child.