Repository navigation
Conversation
|
@tevinch is attempting to deploy a commit to the Tailwind Labs Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3897.
A Combobox with a union value type such as
string | Optionrejects validbyandvirtual.disabledcallbacks whenmultipleis a boolean ortrue. The multiple branch appliesNoInferbeforeEnsureArray, which can collapse the union to its common properties. It can also accept unrelated virtual options.This follows the use-site approach suggested in the report: apply
NoInferafter deriving the array or element type forby,virtual.optionsandvirtual.disabled. Runtime code and the sharedEnsureArrayhelper are unchanged.The compiler-backed regression uses real Combobox JSX. It covers primitive/object and object/object unions, boolean and literal multiple modes, inferred arrays, incompatible callbacks/options, and option-driven type widening. It fails on the original source and passes with this change using the repository's TypeScript 5.4.3.
Validation:
npm test -- --runInBand: 56 suites, 2,046 tests and 100 snapshots pass; 36 tests skipped. An initial untouched-source run hit a Vue transition timing snapshot; the final full run passes without changing it.