Repository navigation
Conversation
Contributor
Author
|
Closing as superseded. The chart already exposes operator.tolerations, and unraid-lab already sets the required runner and control-plane tolerations in its GitOps values. Making the runner taint the chart default would unnecessarily schedule operators onto a cluster-specific taint for every installation. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
imp.dev/runner=true:NoScheduletaintValidation
helm templaterenders the operator tolerationhelm unittest charts/imp -f tests/operator-deployment_test.yaml: 7 passed; 1 pre-existing failure expects image0.1.0while origin/main defaults to0.9.0git diff --checkLive impact: not deployed; the current unraid-lab GitOps Application pins an older Imp commit.