Repository navigation
fix(agent): restore shared suspend snapshot storage - #105
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The nightly ScaleToZero test can now write the Firecracker snapshot files where the agent created the snapshot directory. This restores the shared node-local mount that was lost from the agent chart.
Without it, Firecracker returned
Cannot perform open on the snapshot backing file, leaving the VM stuck inSuspendinguntil the test timed out.Test plan
helm templateconfirms the agent mounts/var/lib/imp/suspendfrom the node.helm unittestpasses the shared suspend-storage regression test.