Skip to content

fix(deps): declare to-buffer imported by the ES bundle - #11097

Open
sebdanielsson wants to merge 1 commit into
swagger-api:mainfrom
sebdanielsson:fix/declare-to-buffer
Open

sebdanielsson wants to merge 1 commit into
swagger-api:mainfrom
sebdanielsson:fix/declare-to-buffer

Conversation

@sebdanielsson

Copy link
Copy Markdown

swagger-ui-es-bundle-core.js bundles sha.js, whose 2.4.12 release added require('to-buffer'), so the published bundle now has an external import * from "to-buffer" that neither swagger-ui nor swagger-ui-react declares (like base64-js/ieee754 for buffer). It only resolves today through hoisting and fails under strict node_modules layouts such as pnpm's isolated linker or Yarn PnP; background: https://nubjs.com/blog/phantom-dependencies-package-extensions

@sebdanielsson

Copy link
Copy Markdown
Author

@robert-hebel-sb thoughts on this?😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant