Repository navigation
fix(hls): preserve caller isolation in persistent HTTP reads - #837
Merged
superuser404notfound merged 2 commits intoOct 21, 2026
Conversation
Keep the non-Sendable chunked framing on the cancellation handler caller's isolation rather than sending it to the generic executor. Add chunked read coverage through cancellation handlers. Copilot-Session: e3687c50-89d2-4a1a-86ea-dc2326878fc6
Keep the progress closure in the same isolation through nextBytes as well; exercise a progress callback that reads the consumer's accumulated bytes. Copilot-Session: e3687c50-89d2-4a1a-86ea-dc2326878fc6
superuser404notfound
merged commit Oct 21, 2026
3450f1c
into
superuser404notfound:main
4 checks passed
Owner
|
Thanks for the fix and the regression test! Merged in 3450f1c on top of current main (changelog entry moved under Unreleased > Fixed); the full suite is green, and it ships with the next release. One note for the record: on Xcode 27.0 (27A266a, Swift 6.4.0.34.1) I could not reproduce the error. Main builds clean for tvOS in Debug and Release, and the new test compiles even against the unchanged transport code. Since both callers are nonisolated, the change does not alter where the reads run, so it is safe either way. If the Plozz build uses a different Xcode build or extra concurrency settings (approachable concurrency, default actor isolation), knowing which would help catch the next case of this in CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore Swift 6.4 compilation of persistent HTTP body reads without making mutable chunked framing or progress closures
Sendable.The 7.40.0 source fails in a consuming tvOS application with
sending 'current' risks causing data racesinBody.next(). Adding isolation only toreadChunkreveals the same error forprogresswhen it reachesnextBytes.What changed
readChunkandnextByteswith anisolated (any Actor)? = #isolationparameter. This keeps framing and progress callbacks in the caller's isolation domain across both awaits.Sendableconformances.Test plan
Issue732PersistentHTTP1Testspassed with no skips, includingtestChunkedReadsKeepFramingAcrossCancellationHandlers. The new test verifies the complete payload and reusable final framing.Checklist
CHANGELOG.mdupdatedfeat(...),fix(...),chore(...))