Repository navigation
Resolve 'any' and retired regions in launch manifests - #5348
Merged
Merged
Conversation
`fly launch --from-manifest` and `fly launch plan generate --region` put the manifest's region straight into the plan, skipping determineRegion. "any" is what placements takes for "the best region", and what the launcher and agents pass when they don't care, but the plan summary looked it up as a region code and failed: region any not found. Is this a valid region according to `fly platform regions`? A manifest region of "any" or "" now becomes the nearest region from /platform/regions, as determineRegion does for a fresh launch.
The GitHub launcher passes a region to `fly launch plan generate`, which
skips determineRegion and its deprecatedRegionReplacements, so a retired
region like qro or bom reached the plan as is: the summary failed with
"region bom not found", or the Machines API refused it ("Region qro is
deprecated and cannot have new resources provisioned").
A manifest's retired region now becomes its listed replacement, and a
deprecated region missing from that list (bom today) becomes the closest
region still open to new apps. A region that isn't on the list at all
fails up front, saying to pick one from `fly platform regions`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fly launchcan fail withregion any not found,region bom not foundorRegion qro is deprecated.Loading a launch manifest (
--from-manifest, andfly launch plan generate --region X) skipsdetermineRegion, so"any", an empty region or a retired code reached the plan unchanged. This PR:"any"or an empty region in a manifest to the nearest region from/platform/regions;fly platform regionsfor unknown codes.Complements #5333, which covers the
determineRegion/fly.toml path. The only conflict with #5333/#5335 is tests appended toplan_builder_test.go.