Repository navigation
Conversation
PostgreSQL Package Dependency Analysis: PR #2490
SummaryNo packages had MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Dependency ChangesExtracting PostgreSQL 15 dependencies...
Runtime Closure Size
Raw Dependency ClosurePostgreSQL 17 Dependency ChangesExtracting PostgreSQL 17 dependencies...
Runtime Closure Size
Raw Dependency Closure |
PostgreSQL Extension Dependency Analysis: PR #2490
SummaryNo extensions had dependencies with MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Extension DependenciesPostgreSQL 17 Extension DependenciesOrioleDB 17 Extension Dependencies |
brainrake
requested changes
Oct 9, 2026
brainrake
left a comment
brainrake
left a comment
Collaborator
There was a problem hiding this comment.
The PG15 guard lives in four places now. Can the setting live in a PG17+ only include instead?
| @@ -0,0 +1 @@ | |||
| SELECT (SELECT setting FROM pg_settings WHERE name = 'summarize_wal') = 'on' AS summarize_wal_default_ok; | |||
Collaborator
There was a problem hiding this comment.
Only runs on plain 17. Add a z_orioledb-17_ variant.
| #wal_skip_threshold = 2MB | ||
|
|
||
| summarize_wal = on # run WAL summarizer for 17 and up | ||
| #wal_summary_keep_time = '10d' # when to remove old summary files; 0 = never |
Collaborator
There was a problem hiding this comment.
Suggested change
| #wal_summary_keep_time = '10d' # when to remove old summary files; 0 = never | |
| #wal_summary_keep_time = '10d' # when to remove old summary files; 0 = never | |
Nit: Restore the blank line before #commit_delay.
| echo "port = ${pgPort}" | ||
| echo "session_preload_libraries = 'supautils'" | ||
| echo "dynamic_library_path = '${supautils}/lib:\$libdir'" | ||
| ${lib.optionalString (pgpkg.version != "15") ''echo "summarize_wal = on"''} |
Collaborator
There was a problem hiding this comment.
Suggested change
| ${lib.optionalString (pgpkg.version != "15") ''echo "summarize_wal = on"''} |
This line configures the pgTAP cluster. z_17_wal_summarize runs on the pg_regress cluster, which run-server.sh.in builds from the j2 file, so it already gets the setting. No pgTAP test reads summarize_wal. Drop the line, or say here why the summarizer should run during the pgTAP step.
Comment on lines
+97
to
+103
| - name: Disable summarize_wal on PG15 (GUC only exists from PG17) | ||
| when: psql_version == 'psql_15' | ||
| ansible.builtin.replace: | ||
| path: '/etc/postgresql/postgresql.conf' | ||
| regexp: '^summarize_wal = on' | ||
| replace: '#summarize_wal = on' | ||
|
|
Collaborator
There was a problem hiding this comment.
This task is skipped at stage 1 (psql_version=psql_), so the line stays active and stage 2 fails at pg_ctl start. Remove it here and do the edit in stage2-setup-postgres.yml. PG15 builds now fail.
Comment on lines
+1
to
+6
| SELECT (SELECT setting FROM pg_settings WHERE name = 'summarize_wal') = 'on' AS summarize_wal_default_ok; | ||
| summarize_wal_default_ok | ||
| -------------------------- | ||
| t | ||
| (1 row) | ||
|
|
Collaborator
There was a problem hiding this comment.
Only runs on plain 17. Add a z_orioledb-17_ variant.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Package version diff: none (aarch64-linux, x86_64-linux) |
|
Found 240 test failures on Blacksmith runners: Failures
...and 230 more test failures. View all on Blacksmith
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light.svg)
encima
force-pushed
the
feat/enable-wal-summarize
branch
from
October 16, 2026 13:06
d06f741 to
f162251
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
What is the current behavior?
summarize_walis not enabledWhat is the new behavior?
summarize_walis on for PG17 and beyond. It does cause PG to use an additional process but its load is minimal and can help with incremental backups (natively, it is required to beon)Additional context
Resolves MPG-1274