Repository navigation
ci/test: Clean up unnecessary/dead steps - #2476
Conversation
4185000 to
4caff50
Compare
I noticed that there was a bunch of dead code here so delete it. dbmate-tool doesn't need hcl files nor ARGS/result so those go away. The steps creating POSTGRES_MAJOR_VERSION and PGMAJOR were also completely unnecessary as the output from prepare step/matrix value is usable as is, I decided to rename it so it uses the common named used throughout the repo for consistency.
No point running this on its own *and* as part of nix-build so lets drop the non-workflow-call cases.
4caff50 to
2f98c43
Compare
All these names have a long common prefix which means the GHA UI truncates the most interesting information. So I'm renaming these so the Summary view is more informative at a glance. I also tweaked some `needs` that didn't really need to be explicit.
2f98c43 to
8be299d
Compare
| - nix-build-checks-aarch64-darwin | ||
| - nix-build-checks-aarch64-linux | ||
| - nix-build-checks-x86_64-linux | ||
| - checks-aarch64-darwin |
There was a problem hiding this comment.
Is Darwin run; Thought it was excluded in the previous PR? 🤔
There was a problem hiding this comment.
darwin is also excluded from the amis list below
There was a problem hiding this comment.
checks-aarch64-darwin is for the nix checks, which we do run for all 3 flavors. This is stuff like linters, formatters, nixosVMTests etc. If you are referring to #2477, whats being skipped there is nixos-tests for aarch64-darwin which are the qemu based nixos vm tests. No point doing those I guess.
Darwin being excluded from amis is correct too, we don't build darwin AMIs. The needs was dropped because there's no reason to depend on darwin binaries if they aren't going to be used in the AMIs.
|
Will merge once develop is green |
2 participants
What kind of change does this PR introduce?
CI Maintenance
What is the current behavior?
We have pretty bad names for jobs/steps since they share long redundant prefixes thus causing GHA UI to truncate the more useful information. For example
nix-build-packages-aarch.... There's no real useful information fromnix-build-prefix.Also the
testworkflow is a bit of a misnomer, its only testing the post migration dump schema matches what is in git. So I renamed it to a better one.Ditto the
docker-image-testworkflow step, its more building container images.What is the new behavior?
Better names:
nix-build-packages-aarch64-linuxbecomesbuilds-aarch64-linuxnix-build-checks-aarch64-linuxbecomeschecks-aarch64-linuxSo any truncation will be minimal.