Repository navigation
chore: set search path in migration - #2410
Merged
Merged
Conversation
imor
reviewed
Sep 3, 2026
imor
approved these changes
Sep 3, 2026
imor
left a comment
imor
left a comment
Contributor
There was a problem hiding this comment.
LGTM, graphql_public.graphql no longer set search_path to empty.
utkarash2991
approved these changes
Sep 3, 2026
staaldraad
force-pushed
the
etienne/prodsec-248
branch
from
September 3, 2026 08:55
cb5ea9a to
88de835
Compare
Package version diff: none (aarch64-linux, x86_64-linux) |
PostgreSQL Extension Dependency Analysis: PR #2410
SummaryNo extensions had dependencies with MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Extension DependenciesPostgreSQL 17 Extension DependenciesOrioleDB 17 Extension Dependencies |
PostgreSQL Package Dependency Analysis: PR #2410
SummaryNo packages had MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Dependency ChangesExtracting PostgreSQL 15 dependencies...
Runtime Closure Size
Raw Dependency ClosurePostgreSQL 17 Dependency ChangesExtracting PostgreSQL 17 dependencies...
Runtime Closure Size
Raw Dependency Closure |
mmlb
force-pushed
the
etienne/prodsec-248
branch
from
October 16, 2026 15:10
906ad7b to
231029d
Compare
Collaborator
|
lgtm, I rebased on top of develop and renamed |
mmlb
enabled auto-merge
October 16, 2026 15:11
mmlb
approved these changes
Oct 16, 2026
|
You may not want to set an empty search path here. Take this scenario below. Basically a user can shadow an empty search path with relations created in pg_temp because pg_temp is searched first for relations (but not functions). This can be overridden by explicitly setting |
Member
Author
Great catch and thanks @AndrewJackson2020 🙏🏼 completely forgot about this nasty footgun with search_path. |
I'm using something like the below for this. Keep in mind this is only a security issue for security definer functions. For other functions this is arguably just a DX issue. I would ultimately like to find a linter that can catch stuff like this and maybe nudge us towards using schema qualified references. I opened an issue with plpgsql_check and the maintainer there seems to be game to implementing more checks around this. maybe Postgres-language-server could provide this as well. Was also thinking we should add this as a warning in splinter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A number of Supabase owned functions are created without a search_path. This breaks from best practice and can lead to unintended side-effects if the current_user search_path changes.