Repository navigation
chore: add plpgsql_check to testing - #318
Draft
AndrewJackson2020 wants to merge 2 commits into
Draft
AndrewJackson2020 wants to merge 2 commits into
AndrewJackson2020 wants to merge 2 commits into
Conversation
AndrewJackson2020
force-pushed
the
plpgsql_check
branch
from
October 14, 2026 19:34
9b494bf to
41b7308
Compare
AndrewJackson2020
force-pushed
the
plpgsql_check
branch
from
October 14, 2026 20:20
ac76d69 to
640deb9
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds plpgsql_check to the pytest suite. It found 1 unused variable and a non returning function. Not critical but still nice to catch stuff like that in a deterministic/systematic way. Would be nice to figure out if there are any other checks that the maintainer would be willing to add that could benefit us here.
Want to hold off on merging this until I can get #304 merged. Also want to see an official xpg bump before merging this. Keeping this in draft until that happens.