Skip to content

Release 7.0.9 with bounded delegation and Agy startup diagnostics - #235

Draft
sumitake wants to merge 1 commit into
mainfrom
dev/codex/plugin-issues-20261018
Draft

sumitake wants to merge 1 commit into
mainfrom
dev/codex/plugin-issues-20261018

Conversation

@sumitake

@sumitake sumitake commented Oct 19, 2026 •

Copy link
Copy Markdown
Owner

Draft: release qualification is incomplete. The OpenCode Go credential requires its approved host workflow; all failed evidence is preserved. Reporting clarification is tracked in #234.

Workers can mistake prose timing for an enforced bound or spend their task searching for a test environment; SDK review findings can also assume the wrong method contract. Version 7.0.9 makes delegation bounds and the validation handoff explicit, adds method-level SDK regressions, and imports signed/notarized runtime 5.0.10 for both macOS architectures with bounded, nonsecret Agy startup-failure hints.

The hints preserve status, content and single-attempt behavior; ambiguous native evidence remains ambiguous. This does not repair or copy a host's native login. Wire schema 12, 12 actions, eight logical agents and carrier bindings are unchanged. Claude remains admitted only for document intent; #162 stays open for separately qualifying additional capabilities.

The release also refreshes its version-bound project-estimation bootstrap. Calibration warnings are retained; pricing applies only to configured model records, unknown models remain unpriced, and numeric quotas remain unknown.

Addresses #218, #219, #220 and #233. Closeout follows verified publication, rather than this source merge.

Validation:

  • 279 public tests and 461 script tests pass under the supported host interpreter. The original stale 5.0.9 diagnostic assertion failure is retained; only its expected version was corrected to 5.0.10.
  • Generation, marketplace, changelog preview, release consistency, maintenance receipt, active-tree/full canonical history, secret and Python API gates pass.
  • Fourteen live matrix cases have substantive fixture answers; the OpenCode Go case is unmet after a native expired-key error, preserved without replay. Provider-free planning and the packaged Grok protocol qualifier pass. Independent signed Intel execution under Rosetta passes planning and a fresh Gemini document canary. Merge/publication remain blocked on the approved OpenCode credential workflow and a distinct fresh missing-case qualification after verified repair.
  • Clean signed-commit archive, checksum and SPDX rehearsal passes: 184 files, both signed/notarized architectures, archive SHA256 482e59a43f1bf48d725f99780d281f824b716a0979a9cc534a276412480ada1d. This is rehearsal evidence, not publication.

Independent exact-head source review: APPROVE for source and draft review readiness, with no source blockers. Complete review and primary adjudication bind 9a03c9c84a527c20efa4b38ea2c2cc906d8f5f86 to response-scoped native Google lineage (primary/contributors: OpenAI). The OpenCode host-qualification hold remains; source approval does not grant merge or publication authority.

author: Codex
standing_directives: Read AGENTS.md and docs/public-governance.md; public source/release boundaries and signed private-producer handoff followed.
tier: 3
cross_check: PENDING — source review is complete; OpenCode native credential and substantive missing-case qualification remain unmet. Merge/publication remain on hold.
post_condition: Verify the merged tree, compile changelog through its governed PR, then cut and verify signed v7.0.9 assets; snapshot and verify installed members before final documentation closeout.
mcp_coverage_gap: FILED: #234
contributor_rights: OWNER-AUTHORED
operator_reserved: no

@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sumitake

Copy link
Copy Markdown
Owner Author

Independent exact-head source governance — request e46bc64b-f420-4391-8625-20a8ae0e36f9, head 9a03c9c84a527c20efa4b38ea2c2cc906d8f5f86.

Reviewer: Google, verified through correlated response-scoped native generation metadata (agy.generation_metadata.model, gemini-4-argon, response SHA256 5f5c0c23e0b5b2f392ae4082fffb8663a060beb3ed5b1e70d0db71a876af3d87). Primary and contributing author family: OpenAI. Exact source/tree and cleanup independently verified. One attempt, no replay.

The complete review text follows. Only private checkout URL prefixes were normalized to exact-commit public blob URLs. Original raw UTF-8 SHA256: e2dac5b42785dbd60bf16c0816cd540d5632a55ce0669dced6390fe0ed83a06b; full original and native wrapper remain preserved privately.

Governance Review — agent-collab 7.0.9 (9a03c9c84a527c20efa4b38ea2c2cc906d8f5f86)

Source Verdict: APPROVE (Source & Draft Review Readiness) — 0 source blockers found in fa79ada3266662cc678e757d816ec7fb722c3d71..9a03c9c84a527c20efa4b38ea2c2cc906d8f5f86.
Host Qualification / Merge & Publication Gate: ON HOLD pending external native credential restoration for the unmet OpenCode Go / Zhipu carrier qualification case and completion of one distinct fresh fixture verification case after verified credential repair.


1. Source Identity & Clean Tree Verification

  • Checked-out HEAD: 9a03c9c84a527c20efa4b38ea2c2cc906d8f5f86 (confirmed via git rev-parse HEAD).
  • Working tree & ignored status: Clean (git status --porcelain --ignored is empty before and after read-only checks; 545 tracked files in git ls-files).
  • Reviewed range: fa79ada3266662cc678e757d816ec7fb722c3d71..9a03c9c84a527c20efa4b38ea2c2cc906d8f5f86 (178 files changed: 523 insertions, 174 deletions, plus 90 binary bundle members across darwin-arm64 and darwin-x86_64).
  • Reviewer family observation: Reviewed in a read-only Antigravity session running Google Gemini (Gemini 4 Argon High), distinct from the OpenAI-family primary and artifact authors.

2. Scope & Contract Verification

#218 & #219 — Worker / Dev-Delegate Inactivity Lease, Cancellation, and Validation Handoff

  • Source & generated parity: skill-specs/worker.md, skill-specs/dev-delegate.md, and the shared routed-skill injection block in scripts/build_skills.py match all 53 generated plugins/agent-collab/skills/*/SKILL.md files (python3 scripts/build_skills.py --check and python3 scripts/build_marketplace.py --check both pass).
  • Lease & cancellation semantics: Guidance accurately distinguishes prose duration expectations from the top-level deadline_ms admitted-progress inactivity lease (24-hour default 86_400_000 ms when omitted, renewable on valid progress marks in runtime_client.py, and clamped/forwarded by coordinator.py). Single-caller cancellation ownership, runtime cleanup verification, retained partial outputs, and the prohibition on replaying consumed work units or reporting caller cancellation as a provider outage are consistently stated.
  • Validation handoff & executable recipe: Primary-owned validation is established as the default. Worker checks require an exact preverified interpreter path, focused command, and verified process-local PATH when a child interpreter is invoked by a generic name, while prohibiting environment/home/cache/sibling searches and dependency installs. The Python request recipe in skill-specs/worker.md is directly compiled and tested through coordinator.main() and runtime_client._envelope_document() in tests/test_routing_coordinator.py.

#220 — External API / SDK Method-Contract Grounding & Blinded Fixtures

  • Review guidance: skill-specs/code-review.md and plugins/agent-collab/skills/code-review/SKILL.md require external API blockers to cite the exact called method in the supplied/installed implementation or version-matched official documentation, inspect wrapper serialization and method-specific overloads before asserting native/FFI type requirements, state uncertainty and the smallest read-only check when evidence is unavailable, and match fake-client assertions to the actual method contract.
  • Fixtures, rubric, and unit tests: tests/fixtures/sdk-method-contracts/sdk.py, case_a.py, case_b.py, rubric.md, and tests/test_sdk_method_contract_fixture.py cleanly verify that Secrets.get and Secrets.list serialize str arguments via json.dumps (case_a.py), reject UUID objects with TypeError in json.dumps (case_b.py), and keep Secrets.create(UUID) (identifier.bytes.hex()) distinct while keeping rubric.md excluded from disposable reviewer evaluation trees.

#233, #214, #162 — Runtime 5.0.10, Manifest & Bundle Integrity, and Release Prose Boundaries

  • Closed manifest & bundle verification:
    • plugins/agent-collab/runtime-manifest.json SHA-256 is a2b2ee3618847f41dcb63c535aa8f060e3a43ccc69579db46f8c80b145159846.
    • wire_contract_sha256 is unchanged at a675807e0ff5f0544d7cc9d659914ce2dadac9be8efd0fb56635815e5c3e842a (schema 12, protocol 5, contract 4, 12 logical actions, 8 logical agents).
    • arm64 bundle identity 621ffc01b3401766e947a23f1f67d9b7918d7155430d79595e4fd2a26d2fb4c7 (45 files, 19724896 bytes, runtime 5.0.10) and x86_64 bundle identity b8993ebfa76304604f989ccf9bb3433bf8ef7dff1e3033d24f61940ad99d39c2 (45 files, 18718448 bytes, runtime 5.0.10) match runtime_bundle.compute_bundle_identity and every member file's byte size and SHA-256 on disk.
    • Note on evidence planes: Public source inspection proves closed schema/manifest/digest/bundle-identity consistency, version pins (7.0.9 / 5.0.10), and negative controls in scripts/test_stage_runtime_handoff.py; online Apple notarization, live carrier behavior, and archive rehearsal outputs remain separate caller-owned verification evidence.
  • Release & package documentation: README.md, plugins/agent-collab/README.md, docs/migration-from-legacy-packages.md, and changelog.d/2026-10-18-001-worker-review-runtime-diagnostics.md keep a single latest-only ## What's new - v7.0.9 showcase in root README.md, keep v7.0.8 (5.0.9) clearly identified as the current published release until 7.0.9 qualification/merge/publication finish, bound runtime 5.0.10 changes to optional Agy startup hints without altering status/content/retry/admission or claiming cross-host login repair, and keep Claude admitted only for context.documents.intent (runtime: qualify omitted native Claude profiles with fresh exact cases #162).

Project-Estimation Bootstrap Data (7.0.9 / Schema 3)

  • plugins/agent-collab/project-estimation-data/maintenance-receipt.json is bound to version: "7.0.9", schema_version: 3, calibration_state: "bootstrap", calibration_status: "fresh", source_cutoff_date: "2026-10-19", generated_date: "2026-10-19", and receipt_sha256: "e96c80d2849294da3b48a85104427d16fb35db37bdf1cee0809e57c80831c737".
  • pricing-snapshot.json removes the unconfirmed gemini-3.7-flash records while retaining verified 3.6 records; quota-snapshot.json preserves status: "unknown" across all four providers and cross-binds operator-notification.json (decision: "quota_unknown").
  • python3 scripts/verify_project_estimation_maintenance.py --root . --expected-version 7.0.9, python3 scripts/check-public-export-safety.py --active-tree, python3 scripts/secret_scan.py, and git diff --check all pass.

3. Blockers vs. Optional Follow-Ups

  • Source Blockers: None.
  • Host / Release Qualification Blocker (External to Source Bytes):
    • Staged live carrier qualification remains incomplete because the OpenCode Go / Zhipu case returned only ACP catalog/control traffic ending in native RPC error -32603 (APIError, expired key) with zero agent chunks. Mechanical qualified: true / provider_status: ok fields do not satisfy fixture acceptance. Merge and publication must remain on hold until the approved native credential is restored and one distinct fresh fixture case for the missing OpenCode carrier succeeds after verified correction.
  • Optional Non-Blocking Follow-Ups (Pre-existing in Unchanged Code):
    1. scripts/test_stage_runtime_handoff.py (lines 106–117 and 165–177): _make_handoff and _make_matrix_handoff create intermediate runtime/ and runtime/darwin-* directories with mkdir(parents=True) without explicitly applying .chmod(0o755) to those parent directories. Under a restrictive shell umask (such as 0o077), _validate_handoff_tree fails closed on the intermediate directory mode (0o700 != 0o755); under standard umask 0o022, all 73 tests pass.
    2. scripts/verify_project_estimation_maintenance.py (lines 196–220): _open_dir_chain(root) walks from / downward using os.open(..., dir_fd=fd) when root is an absolute path, which fails in sandboxes that block opening ancestor directories above the workspace root (such as /Users) even when the repository root itself is readable (passing --root . succeeds).

Primary adjudication: APPROVE the source for draft review; retain the OpenCode host-qualification HOLD on merge and publication. I read the complete response, matched its native response hash, verified the source against all 545 commit blobs, and checked the cited changed contracts. The two optional findings affect preexisting fixture-directory setup and an unchanged absolute-root sandbox traversal; they do not invalidate the current passing supported-host gates or introduce a source regression. They remain follow-up candidates. No source edit or repeated canary is justified by these observations. The approved native credential workflow and one distinct missing-case fixture after verified repair remain required before promotion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant