Repository navigation
Boundary update with testcases - #27
Conversation
|
flamelet_table_h2 was not working anymore, still has to be updated and checked. |
EvertBunschoten
left a comment
There was a problem hiding this comment.
Very nice! Thank you also for doing some clean up in other parts of the code and the test cases. I especially like the extensive visualization functions that have been added to the table generator. Overall, I think some of the functions can be made shorter and there is still one bug where the table plots are not actually visualized when specifying show=True.
Co-authored-by: Evert Bunschoten <38651601+EvertBunschoten@users.noreply.github.com>
Co-authored-by: Evert Bunschoten <38651601+EvertBunschoten@users.noreply.github.com>
|
I will try to finish this asap. with the note that the boundary curve treatment could be improved still and Josh and Berk both have worked on this separately and got their own solutions. |
EvertBunschoten
left a comment
There was a problem hiding this comment.
Looks great! Small point: you can reduce the details in docstrings of private methods. Docstrings are only useful for functions used by the user.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Proposed Changes
Modify 2D table edges to better follow curved boundaries
add fixed strain rate testcase
add CH4 premixed testcase
To do for this PR:
regression test the new cases
Related Work
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --allto format old commits.