Skip to content

Boundary update with testcases - #27

Merged
bigfooted merged 16 commits into
developfrom
new_fixed_strain
Oct 24, 2026
Merged

bigfooted merged 16 commits into
developfrom
new_fixed_strain

Conversation

@bigfooted

@bigfooted bigfooted commented Sep 6, 2026 •

Copy link
Copy Markdown
Collaborator

Proposed Changes

Modify 2D table edges to better follow curved boundaries
add fixed strain rate testcase
add CH4 premixed testcase

To do for this PR:
regression test the new cases

Related Work

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • I have updated the list of python modules in required_packages.txt and environment.yml, if necessary.
  • I have properly commented my changes.
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have updated the documentation, if necessary.
  • I have added a test case that demonstrates my contribution, if necessary.

@bigfooted

Copy link
Copy Markdown
Collaborator Author

flamelet_table_h2 was not working anymore, still has to be updated and checked.

@EvertBunschoten EvertBunschoten left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thank you also for doing some clean up in other parts of the code and the test cases. I especially like the extensive visualization functions that have been added to the table generator. Overall, I think some of the functions can be made shorter and there is still one bug where the table plots are not actually visualized when specifying show=True.

Comment thread Manifold_Generation/LUT/MeshTools.py Resolved
bigfooted and others added 5 commits September 13, 2026 11:29
Co-authored-by: Evert Bunschoten <38651601+EvertBunschoten@users.noreply.github.com>
Co-authored-by: Evert Bunschoten <38651601+EvertBunschoten@users.noreply.github.com>
@bigfooted

Copy link
Copy Markdown
Collaborator Author

I will try to finish this asap. with the note that the boundary curve treatment could be improved still and Josh and Berk both have worked on this separately and got their own solutions.

@bigfooted bigfooted changed the title [WIP] Boundary update with testcases Boundary update with testcases Oct 15, 2026

@EvertBunschoten EvertBunschoten left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Small point: you can reduce the details in docstrings of private methods. Docstrings are only useful for functions used by the user.

@bigfooted
bigfooted merged commit 6119558 into develop Oct 24, 2026
4 checks passed
@EvertBunschoten
EvertBunschoten deleted the new_fixed_strain branch October 26, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants