Repository navigation
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
column_namesinGetIndexesonly came fromindkey, which misses columns used in index expressions and predicates. This adds those columns frompg_depend, soaddDepsOnRelationAddAlterIfNecessarydrops the index before the column.Motivation
Fixes #316
Testing
Added acceptance cases for a predicate-only column, an expression column and a partitioned table. All fail without the change. Full suite passes on Postgres 16 and 17. On 14 and 15 I only see the temp database
CREATE DATABASEhitting the 3s statement timeout locally, which main does too. Lint clean, sqlc regenerated with the codegen image.