Skip to content

Version 3.9.2 - #1306

Merged
mulkieran merged 8 commits into
stratis-storage:masterfrom
mulkieran:version-3.9.2
Nov 5, 2026
Merged

mulkieran merged 8 commits into
stratis-storage:masterfrom
mulkieran:version-3.9.2

Conversation

@mulkieran

@mulkieran mulkieran commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

@mulkieran mulkieran self-assigned this Nov 4, 2026
@mulkieran mulkieran moved this to In Progress in 2026November Nov 4, 2026
@mulkieran mulkieran added this to the 3.9.2 milestone Nov 4, 2026
@mulkieran
mulkieran marked this pull request as ready for review November 4, 2026 16:22
@mulkieran

Copy link
Copy Markdown
Member Author

@coderabbitai review

This is a new patch version that just reverts all commits that properly belong in the next minor version, leaving only bug fixes, maintenance, etc.

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Nov 4, 2026

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The CLI now targets D-Bus interface revision r9, lowers its minimum daemon version and CLI version, removes pool metadata usage from detailed output, and removes the pool remove-cache command and its integration tests.

Changes

Pool API and command updates

Layer / File(s) Summary
Daemon compatibility and pool detail
src/stratis_cli/_actions/_constants.py, src/stratis_cli/_version.py, src/stratis_cli/_actions/_introspect.py, src/stratis_cli/_actions/_list_pool.py, docs/stratis.txt
The minimum daemon version changes to 3.9.2, and the CLI version changes to 3.9.1. D-Bus interface revisions change to r9. The pool detail output and documentation no longer include metadata usage.
Remove the cache-removal command
src/stratis_cli/_actions/_introspect.py, src/stratis_cli/_parser/_pool.py, src/stratis_cli/_actions/_pool.py, docs/stratis.txt, tests/integration/pool/test_remove_cache.py
The pool interface, parser, and pool action no longer include remove-cache. The command documentation and integration tests were removed.

Estimated code review effort: 2 (Simple) | ~15 minutes

Change: Other

Merge Risk: Minimal · up to 16cc1

No concrete merge-blocking risk is established by the reviewed changes.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title identifies the version-focused purpose of the pull request and matches the stated objective to prepare Version 3.9.2.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 3 files.

Finishing Touches
Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share
Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 377fead7-277e-4a12-8be7-5ad6983f05ea
Commits

Reviewing files that changed from the base of the PR and between e68dadf and 16cc121.

Files selected for processing: 8
  • docs/stratis.txt
  • src/stratis_cli/_actions/_constants.py
  • src/stratis_cli/_actions/_introspect.py
  • src/stratis_cli/_actions/_list_pool.py
  • src/stratis_cli/_actions/_pool.py
  • src/stratis_cli/_parser/_pool.py
  • src/stratis_cli/_version.py
  • tests/integration/pool/test_remove_cache.py
Files with no reviewable changes: 5
  • src/stratis_cli/_actions/_list_pool.py
  • docs/stratis.txt
  • src/stratis_cli/_parser/_pool.py
  • src/stratis_cli/_actions/_pool.py
  • tests/integration/pool/test_remove_cache.py

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

@mulkieran mulkieran moved this from In Progress to In Review in 2026November Nov 5, 2026
Signed-off-by: mulhern <amulhern@redhat.com>
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran

Copy link
Copy Markdown
Member Author

/packit build

@packit-as-a-service

Copy link
Copy Markdown

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo dnf install -y 'dnf*-command(copr)'
  • dnf copr enable packit/stratis-storage-stratis-cli-1306-copr_pull
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

1 similar comment
@packit-as-a-service

Copy link
Copy Markdown

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo dnf install -y 'dnf*-command(copr)'
  • dnf copr enable packit/stratis-storage-stratis-cli-1306-copr_pull
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@mulkieran
mulkieran merged commit 0e7ffa7 into stratis-storage:master Nov 5, 2026
14 checks passed
@github-project-automation github-project-automation Bot moved this from In Review to Done in 2026November Nov 5, 2026
@mulkieran
mulkieran deleted the version-3.9.2 branch November 5, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant