Repository navigation
crypto: Add BitLocker Clear Key detection and passwordless open - #1212
Draft
Marcondiro wants to merge 1 commit into
Draft
Marcondiro wants to merge 1 commit into
Marcondiro wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Marcondiro
force-pushed
the
master
branch
2 times, most recently
from
September 28, 2026 08:18
3071eba to
07596c9
Compare
Pre-provisioned and suspended BitLocker devices contain an on-disk Clear Key protector. In cryptsetup 2.8+, passing a NULL passphrase allows extracting the VMK using this Clear Key. - Extend BDCryptoBITLKInfo with has_clearkey field - In bd_crypto_bitlk_info(), probe for clear key presence - In bd_crypto_bitlk_open_flags(), allow NULL context to trigger clear key activation - Add test cases in tests/crypto_test.py Assisted-by: Gemini Signed-off-by: Marco Cavenati <cavenati.marco@gmail.com>
| info->backing_device = g_strdup (crypt_get_device_name (cd)); | ||
| ret = crypt_get_sector_size (cd); | ||
| info->sector_size = ret > 0 ? ret : 0; | ||
| info->has_clearkey = (crypt_activate_by_passphrase (cd, NULL, CRYPT_ANY_SLOT, NULL, 0, 0) >= 0); |
Member
There was a problem hiding this comment.
I am not sure if this is a good idea. crypt_activate_by_passphrase can be quite "heavy" function and in general the bd_crypto_*_info functions can be called as a reaction to udev event (device being added). I'll try talking to cryptsetup developer to check if we could get some "cheaper" API to get this information.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR introduces support for Bitlocker Clear Keys: pre-provisioned and suspended BitLocker devices contain this on-disk key in clear, more info on Microsoft's FAQ.
In cryptsetup 2.8+, passing a NULL passphrase allows extracting the VMK using this Clear Key.
Assisted-by: Gemini
Thanks!