Skip to content

chore: workaround for browserslist (PROVCON-5709) - #3001

Merged
darekplawecki merged 5 commits into
mainfrom
chore/provcon-5709--fix-security-issues
Oct 19, 2026
Merged

darekplawecki merged 5 commits into
mainfrom
chore/provcon-5709--fix-security-issues

Conversation

@darekplawecki

Copy link
Copy Markdown
Contributor

Fixes the e2e-react-cra build failure introduced by the browserslist bump (ce4d017):

  Failed to compile.
  ./node_modules/react-router-dom/server.js 215:41
  Module parse failed: Unexpected token (215:41)
  >         v7_partialHydration: opts.future?.v7_partialHydration === true,

Cause

  • The bump pulled in newer caniuse-lite data. With it, every browser matched by the production query (>0.2%, not dead, not op_mini all) supports optional chaining (?.).
  • Babel therefore stopped transpiling ?. in node_modules.
  • CRA 4 uses webpack 4, which can't parse ?..
  • The e2e build uses local elements-core, which imports react-router-dom/server.js. That is where it failed.

Fix

  • Add "chrome 79" to browserslist.production in examples/react-cra/package.json. Chrome 79 is the last version without ?., so Babel transpiles it again.

Impact

  • Only the example app's bundle changes: slightly larger output. The published packages are unaffected.
  • The browserslist CVE fix stays in place.
  • This is a workaround for CRA 4's webpack 4. It can go away if the example moves off CRA.

@darekplawecki
darekplawecki requested a review from a team as a code owner October 19, 2026 11:23
@darekplawecki darekplawecki changed the title Chore/provcon 5709 fix security issues chore: workaround for browserslist (PROVCON-5709) Oct 19, 2026
@netlify

netlify Bot commented Oct 19, 2026

Copy link
Copy Markdown

✅ Deploy Preview for stoplight-elements ready!

Name Link
🔨 Latest commit b561808
🔍 Latest deploy log https://app.netlify.com/projects/stoplight-elements/deploys/6ad5fdc3007385d0755df017
😎 Deploy Preview https://deploy-preview-3001--stoplight-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Oct 19, 2026

Copy link
Copy Markdown

✅ Deploy Preview for stoplight-elements-demo ready!

Name Link
🔨 Latest commit b561808
🔍 Latest deploy log https://app.netlify.com/projects/stoplight-elements-demo/deploys/6ad5fdc36f363182b13b386d
😎 Deploy Preview https://deploy-preview-3001--stoplight-elements-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Oct 19, 2026

Copy link
Copy Markdown

✅ Deploy Preview for stoplight-elements ready!

Name Link
🔨 Latest commit 6cfd251
🔍 Latest deploy log https://app.netlify.com/projects/stoplight-elements/deploys/6ad5fdf14c0325365eab8642
😎 Deploy Preview https://deploy-preview-3001--stoplight-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Oct 19, 2026

Copy link
Copy Markdown

✅ Deploy Preview for stoplight-elements-demo ready!

Name Link
🔨 Latest commit 6cfd251
🔍 Latest deploy log https://app.netlify.com/projects/stoplight-elements-demo/deploys/6ad5fdf18ccbd92ef3febb94
😎 Deploy Preview https://deploy-preview-3001--stoplight-elements-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@darekplawecki
darekplawecki merged commit 42def71 into main Oct 19, 2026
7 checks passed
@darekplawecki
darekplawecki deleted the chore/provcon-5709--fix-security-issues branch October 19, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants