Repository navigation
fix(compiler): source map issues - #6971
Open
stephan-dum wants to merge 9 commits into
Open
stephan-dum wants to merge 9 commits into
stephan-dum wants to merge 9 commits into
Conversation
stephan-dum
marked this pull request as ready for review
October 23, 2026 01:53
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
GitHub Issue Number: #6959
What is the new behavior?
1. source map paths are correct
by adding
dirto all RollupOutputOptions the sourcemap.sources property is correct. This requires to loop all possible outputTargets (similar to collection and customElements output targets)the dir for system output targets was pointing to esmDir which uses now systemDir instead.
es5 builds now are in there own directory using esmEs5Dir
2. only one referenced source map per file
es5 ts.transpileModule added a source map reference for module.ts which is remove now.
minify options format.comments is now applied to all targets. There seams to be an inconsistency with sourcemap reference comment when this option is set it will not remove the reference comment. This means there is no need anymore for the
getSourceMappingUrlForEndOfFilefunction so its completly removed.lazyBundleIdPlugin function is also removed to keep naming of source map reference and the actual source file in sync. This should be already covered by template strings:
Does this introduce a breaking change?
Testing
All unit tests are passing
Added new e2e test cases to prevent it in the future