Repository navigation
Preserve control-flow exceptions when joining pointer parts - #91
Merged
stefankoegl merged 1 commit intoOct 11, 2026
Merged
Conversation
|
coverage: 97.917%. remained the same — muneikh:fix-pointer-join-interruptions into stefankoegl:master |
Owner
|
Good catch, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JsonPointer.join()accepts an iterable of path components. Its bare exception handler also catchesKeyboardInterrupt,SystemExit, andGeneratorExitraised by that iterable, replacing them withJsonPointerException("Invalid suffix"). This prevents cancellation and process termination from reaching the caller.Catch ordinary
Exceptioninstances so invalid suffixes keep the existing error behavior while control-flow exceptions propagate unchanged. Regression tests cover all three exception types and verify object identity. The new cases fail before the change; the complete suite passes afterward (48 tests, 13 subtests).flake8 jsonpointer.py tests.pypasses.