Skip to content

Preserve trailing member-name spaces in pointer files - #89

Merged
stefankoegl merged 1 commit into
stefankoegl:masterfrom
fhgffy:fix-cli-pointer-file-whitespace
Oct 10, 2026
Merged

stefankoegl merged 1 commit into
stefankoegl:masterfrom
fhgffy:fix-cli-pointer-file-whitespace

Conversation

@fhgffy

@fhgffy fhgffy commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

When a pointer is read with -f, strip() removes spaces that belong to the final object member name. For {"a ": "expected", "a": "wrong"}, a pointer file containing /a currently returns "wrong".

Trim CR/LF file line endings while retaining member-name whitespace. The CLI regression covers a file without a line ending and files ending in LF or CRLF.

Validation on Python 3.14: the three regression subtests fail against the original source; all 52 tests pass with the fix; full-repository flake8 passes; coverage is 98%; wheel and sdist builds pass.

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 97.917%. remained the same — fhgffy:fix-cli-pointer-file-whitespace into stefankoegl:master

@stefankoegl
stefankoegl merged commit 5eb90c3 into stefankoegl:master Oct 10, 2026
13 checks passed
@stefankoegl

Copy link
Copy Markdown
Owner

Good catch, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants