Repository navigation
fix: format exact zero as a whole number in fractional - #771
Open
Zhuyuyangyy wants to merge 1 commit into
Open
Zhuyuyangyy wants to merge 1 commit into
Zhuyuyangyy wants to merge 1 commit into
Conversation
staticdev
approved these changes
Oct 31, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Return the integer representation
"0"for exact zero infractional, consistent with the function's whole-number formatting contract.Currently both
fractional(0)andfractional(0.0)return"0/1". The fix checks the already-converted float for exact zero before computing the fraction. Other values retain their existing truncation and denominator-limit behavior; for example, a nonzero0.0001still formats as"0/1"after approximation.Tests cover integer, float, negative and string zero, plus positive/negative whole numbers, fractions, string inputs and approximation controls. The docstring and usage page include the zero example.
Local validation
git diff --checkpassed.This is local Python 3.12 validation; the Nox multi-Python matrix and upstream CI have not been run by this contribution.
Disclosure: this contribution was prepared and checked with AI assistance on behalf of the account owner. It has not received an independent human review.