You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Remove the legacy scripts/roxcurl helper and its container wrapper.
Remove the workflow downloads, extra packages, and Dockerfile setup used to bundle roxcurl.
Remove roxcurl references from the subshell banner and README.
Rationale
The roxie container targets users who want to deploy development versions of StackRox; roxcurl is an ACS engineering utility available from the stackrox/workflow repository. Bundling it added dependencies and maintenance without being an important container use case.
Verification
go test ./... - passed.
go test ./cmd - passed after the banner cleanup.
make docker-build - passed after removing roxcurl from the image.
Confirmed the built image retains roxctl and omits roxcurl:
podman run --rm --entrypoint /bin/bash localhost/roxie:latest \
-c 'command -v roxctl; if command -v roxcurl >/dev/null 2>&1; then echo "unexpected: roxcurl is installed"; exit 1; else echo "roxcurl is not installed"; fi'
/usr/local/bin/roxctl
roxcurl is not installed
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
No actionable comments were generated in the recent review.
Walkthrough
The Docker image now downloads roxcurl and supporting files from a pinned StackRox workflow revision and installs a container-specific wrapper. The local helper script is removed. The README and shell banner identify the workflow source.
Changes: Workflow-provided roxcurl
Layer / File(s)
Summary
Container helper installation and execution Dockerfile, scripts/roxcurl, scripts/roxcurl-wrapper
The Docker image downloads the workflow helper and supporting files from a pinned revision. It installs a wrapper as /usr/local/bin/roxcurl and adds ncurses and which to the runtime packages. The wrapper checks terminal capabilities, supplies a password fallback under the specified conditions, and executes the downloaded helper. The local helper script is removed.
No actionable merge-blocking risk was found in the workflow helper integration.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Title check
The title refers to the removal of roxie’s local roxcurl script, which is a real part of the change. It does not clearly state that the script is replaced by the StackRox workflow helper.
Full details: Docstring Coverage
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Tip
🎯 Customize your risk assessments
Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.
✅ Automatic approvals, with your rules
Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.
Reviewing files that changed from the base of the PR and between 51f190b and 1115aa0.
Files selected for processing: 1
scripts/roxcurl-wrapper
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 9 remain after this review.
@AlexVulaj,
I know that I have suggested to use workflow's roxcurl, but I wasn't aware of how much it would take to integrate it (dependencies in the docker image, a custom wrapper). This is quite a lot IMHO for maybe little gain -- only for the docker image.
The idea behind the roxie docker image has been to enable non-engineers (e.g. product) to quickly spin up clusters with some dev versions of stackrox. I would actually expect that for this audience it would not be a particularly important use-case to have roxcurl available.
I am wondering, what do you think about just getting rid of roxcurl in the image? roxctl should stay, of course. But roxcurl seems like a dev-tool. Maybe it wouldn't be worth to jump through these loops.
@mclasmeier fully agree with that take, and I'm glad we went through the full song and dance of seeing what effort would be involved. I've reworked this entire PR to just remove roxcurl from roxie.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Summary
scripts/roxcurlhelper and its container wrapper.Rationale
The roxie container targets users who want to deploy development versions of StackRox; roxcurl is an ACS engineering utility available from the stackrox/workflow repository. Bundling it added dependencies and maintenance without being an important container use case.
Verification
go test ./...- passed.go test ./cmd- passed after the banner cleanup.make docker-build- passed after removing roxcurl from the image.Confirmed the built image retains roxctl and omits roxcurl:
podman run --rm --entrypoint /bin/bash localhost/roxie:latest \ -c 'command -v roxctl; if command -v roxcurl >/dev/null 2>&1; then echo "unexpected: roxcurl is installed"; exit 1; else echo "roxcurl is not installed"; fi' /usr/local/bin/roxctl roxcurl is not installed