[albertodonato]

ENG-9440

what

Define separate base types for resources and datasources related to platform
and sinistral, each one carrying an api attribute pointing to the
corresponding API class

why

Each resource/datasource interacts with only one API

testing

updated tests

docs

n/a

---

_{Stack created with GitHub Stacks CLI • Give Feedback 💬}

[cubic-dev-ai]

No issues found across 60 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

Architecture diagram

sequenceDiagram
    participant TF as Terraform Core
    participant R as Resource/DataSource<br/>(e.g., accountResource)
    participant B as Base Type<br/>apiResource[T]/apiDataSource[T]
    participant PD as ProviderData<br/>Internal
    participant API as API Client<br/>(*platform.API or *iac.API)

    Note over TF,API: Provider Configure & Runtime Flow

    TF->>R: Configure request
    R->>B: Call embedded Configure()
    B->>PD: GetAPI[T]("resource"/"datasource", ProviderData)
    
    alt ProviderData not nil
        PD->>PD: Type switch on T
        alt T = *platform.API
            PD->>B: Return PlatformAPI
        else T = *iac.API
            PD->>B: Return IaCAPI
        end
        B->>B: Store API client in api field
        B-->>TF: No diagnostics
    else ProviderData is nil
        PD-->>B: Return nil API
        B-->>TF: No diagnostics (nil API)
    else ProviderData has wrong type
        PD-->>B: providerDataError
        B-->>TF: Add diagnostic error
    end

    Note over TF,API: Runtime CRUD Operations

    TF->>R: Read/Create/Update/Delete
    R->>B: Access api field
    B-->>R: API client instance
    R->>API: Call platform/IaC API endpoint
    API-->>R: Response

Loading

_{Re-trigger cubic}

[fwereade]

LGTM, thanks