Repository navigation
chore: release 0.5.39.1 - #89
Merged
Merged
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Architecture diagram
sequenceDiagram
participant User as CLI User
participant CLI as sinistral CLI
participant Version as Version Check
participant Certifi as certifi
participant Provider as Terraform Provider
Note over User,Provider: sinistral CLI 0.5.39.1 runtime flows
User->>CLI: Run sinistral dump command
CLI->>Version: Check package version 0.5.39.1
Version-->>CLI: Version confirmed
CLI->>Provider: Load Terraform provider
Provider->>CLI: Initialize provider
CLI->>Provider: Run dump operation
Provider-->>CLI: Dump output
alt CERTIFI CERTIFICATE CHECK
CLI->>Certifi: Validate SSL certificates
Certifi-->>CLI: Certificates trusted
else INVALID CERTIFICATE
Certifi-->>CLI: Certificate error
CLI-->>User: Error message
end
CLI-->>User: Dump output or error
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Contributor
Author
There was a problem hiding this comment.
No issues found across 5 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Architecture diagram
sequenceDiagram
participant Dev as Developer
participant CLI as Upgrade CLI
participant PyProject as pyproject.toml
participant Ver as packaging.version.Version
participant Test as Test Suite
Note over Dev,Test: Release versioning workflow for sinistral-cli
Dev->>CLI: Run scripts/upgrade.py with bump flag
CLI->>CLI: Validate exactly one of patch/minor/major selected
alt Invalid flag combination
CLI->>Dev: Error: "Only one of --bump-patch/minor/major may be selected"
CLI->>CLI: Exit code 1
end
CLI->>PyProject: Read current version string
PyProject-->>CLI: version (e.g., "0.5.39.1")
CLI->>Ver: Parse version with packaging.version.Version
Ver-->>CLI: Version object (major, minor, micro)
alt bump-patch flag
CLI->>CLI: Increment micro → "0.5.40"
else bump-minor flag
CLI->>CLI: Increment minor, reset micro → "0.6.0"
else bump-major flag
CLI->>CLI: Increment major, reset minor/micro → "1.0.0"
end
CLI->>PyProject: Write upgraded version
CLI->>Dev: Output "sinistral-cli: {current} -> {upgraded}"
Note over Test,PyProject: Verification via test suite
Test->>CLI: Invoke upgrade with test pyproject.toml
Test->>PyProject: Read back version
Test-->>Test: Assert expected version and exit codes
Note over PyProject: Packaging metadata now uses certifi 2026.10.19<br/>for GHSA-6q48-6c7w-9gw2 fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
Bump the package version to 0.5.39.1 and add its NEWS entry. The
release carries the certifi fix for GHSA-6q48-6c7w-9gw2 and the
sinistral dumpprovider fix from #87.why
We publish both fixes without a c7n-left upgrade. A fourth version
component keeps the 0.5.39 match with c7n-left 0.3.39 and sorts
before 0.5.40. PEP 440 rules out a post-release here because the
release changes code and dependencies.
testing
No code changes.
docs
The NEWS.md entry is part of this change.
🤖 Generated with Claude Code