Skip to content

chore: release 0.5.39.1 - #89

Merged
jtroup merged 2 commits into
mainfrom
elmo/namely-amazed-buck
Oct 21, 2026
Merged

jtroup merged 2 commits into
mainfrom
elmo/namely-amazed-buck

Conversation

@jtroup

@jtroup jtroup commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

what

Bump the package version to 0.5.39.1 and add its NEWS entry. The
release carries the certifi fix for GHSA-6q48-6c7w-9gw2 and the
sinistral dump provider fix from #87.

why

We publish both fixes without a c7n-left upgrade. A fourth version
component keeps the 0.5.39 match with c7n-left 0.3.39 and sorts
before 0.5.40. PEP 440 rules out a post-release here because the
release changes code and dependencies.

testing

No code changes.

docs

The NEWS.md entry is part of this change.


🤖 Generated with Claude Code

@jtroup
jtroup requested a review from a team as a code owner October 20, 2026 23:32

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 3 files

Architecture diagram
sequenceDiagram
    participant User as CLI User
    participant CLI as sinistral CLI
    participant Version as Version Check
    participant Certifi as certifi
    participant Provider as Terraform Provider

    Note over User,Provider: sinistral CLI 0.5.39.1 runtime flows

    User->>CLI: Run sinistral dump command
    
    CLI->>Version: Check package version 0.5.39.1
    Version-->>CLI: Version confirmed
    
    CLI->>Provider: Load Terraform provider
    Provider->>CLI: Initialize provider
    CLI->>Provider: Run dump operation
    Provider-->>CLI: Dump output
    
    alt CERTIFI CERTIFICATE CHECK
        CLI->>Certifi: Validate SSL certificates
        Certifi-->>CLI: Certificates trusted
    else INVALID CERTIFICATE
        Certifi-->>CLI: Certificate error
        CLI-->>User: Error message
    end
    
    CLI-->>User: Dump output or error
Loading

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread pyproject.toml

@sampsre sampsre left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtroup

jtroup commented Oct 21, 2026

Copy link
Copy Markdown
Contributor Author

@cubic-ai

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 21, 2026

Copy link
Copy Markdown

@cubic-ai

@jtroup I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.
Architecture diagram
sequenceDiagram
    participant Dev as Developer
    participant CLI as Upgrade CLI
    participant PyProject as pyproject.toml
    participant Ver as packaging.version.Version
    participant Test as Test Suite

    Note over Dev,Test: Release versioning workflow for sinistral-cli

    Dev->>CLI: Run scripts/upgrade.py with bump flag

    CLI->>CLI: Validate exactly one of patch/minor/major selected
    alt Invalid flag combination
        CLI->>Dev: Error: "Only one of --bump-patch/minor/major may be selected"
        CLI->>CLI: Exit code 1
    end

    CLI->>PyProject: Read current version string
    PyProject-->>CLI: version (e.g., "0.5.39.1")

    CLI->>Ver: Parse version with packaging.version.Version
    Ver-->>CLI: Version object (major, minor, micro)

    alt bump-patch flag
        CLI->>CLI: Increment micro → "0.5.40"
    else bump-minor flag
        CLI->>CLI: Increment minor, reset micro → "0.6.0"
    else bump-major flag
        CLI->>CLI: Increment major, reset minor/micro → "1.0.0"
    end

    CLI->>PyProject: Write upgraded version
    CLI->>Dev: Output "sinistral-cli: {current} -> {upgraded}"

    Note over Test,PyProject: Verification via test suite
    Test->>CLI: Invoke upgrade with test pyproject.toml
    Test->>PyProject: Read back version
    Test-->>Test: Assert expected version and exit codes

    Note over PyProject: Packaging metadata now uses certifi 2026.10.19<br/>for GHSA-6q48-6c7w-9gw2 fix
Loading

Re-trigger cubic

@jtroup
jtroup merged commit 68dd152 into main Oct 21, 2026
10 checks passed
@jtroup
jtroup deleted the elmo/namely-amazed-buck branch October 21, 2026 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants